RVO WallThickness bug

General
1

This was thrown up by the static analysis on our build server, in Pathfinding.RVO.Simulator.WallThickness:

public float WallThickness { 
    get { return wallThickness; }
    set { wallThickness = System.Math.Max (wallThickness, 0); }
}

value is never used in the setter, so wallThickness will never change.

1 Like
2

Thanks for the bug report.
I will fix that.

PS: What static analyser are you using?

3

I don’t run the build server but I think it is Gendarme, with a few Unity specific rules bolted on. We generate lots of warnings including a few false positives, and we tend to ignore those in 3rd party code, but this stood out as particularly hinky.

1 Like